linux-kernel - Re: [PATCH 3/3] Add support for the generic backlight device to the TOSHIBA ACPI driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20061013145658.99de9f54.akpm@osdl.org>
Date:	Fri, 13 Oct 2006 14:56:58 -0700
From:	Andrew Morton <akpm@...l.org>
To:	Holger Macht <hmacht@...e.de>
Cc:	linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
	len.brown@...el.com
Subject: Re: [PATCH 3/3] Add support for the generic backlight device to the
 TOSHIBA ACPI driver

On Fri, 13 Oct 2006 12:24:19 +0200
Holger Macht <hmacht@...e.de> wrote:

> +static int set_lcd(int value)
> +{
> +	u32 hci_result;
> +
> +	value = value << HCI_LCD_BRIGHTNESS_SHIFT;
> +	hci_write1(HCI_LCD_BRIGHTNESS, value, &hci_result);
> +	if (hci_result != HCI_SUCCESS)
> +		return -EFAULT;
> +
> +	return 0;

-EFAULT seems a bit random.  Would -EIO be more appropriate?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/