linux-kernel - Re: [PATCH] Readability improvement of open

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20061013073010.GB13531@infradead.org>
Date:	Fri, 13 Oct 2006 08:30:10 +0100
From:	Christoph Hellwig <hch@...radead.org>
To:	Casey Dahlin <cjdahlin@...u.edu>
Cc:	Linus Torvalds <torvalds@...l.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Readability improvement of open_exec()

> +	if (err)
> +		goto out;
> +
> +	inode = nd.dentry->d_inode;
> +	file = ERR_PTR(-EACCES);
> +	if ((nd.mnt->mnt_flags & MNT_NOEXEC) ||
> +	    !S_ISREG(inode->i_mode))

While you're cleaning up things you can put the whole if statement on
one line, it's less than 80 characters long.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/