linux-kernel - Re: [PATCH 20 of 23] Unionfs: Internal include file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <84144f020610130102p4414f91fv9e2e4bee64690a16@mail.gmail.com>
Date:	Fri, 13 Oct 2006 11:02:26 +0300
From:	"Pekka Enberg" <penberg@...helsinki.fi>
To:	"Josef Jeff Sipek" <jsipek@...sunysb.edu>
Cc:	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	torvalds@...l.org, akpm@...l.org, hch@...radead.org,
	viro@....linux.org.uk, mhalcrow@...ibm.com,
	phillip@...lewell.homeip.net
Subject: Re: [PATCH 20 of 23] Unionfs: Internal include file

Hi,

On 10/7/06, Josef Jeff Sipek <jsipek@...sunysb.edu> wrote:
> +static inline void fist_copy_attr_atime(struct inode *dest,
> +                                       const struct inode *src)
> +{
> +       dest->i_atime = src->i_atime;
> +}
> +
> +static inline void fist_copy_attr_times(struct inode *dest,
> +                                       const struct inode *src)
> +{
> +       dest->i_atime = src->i_atime;
> +       dest->i_mtime = src->i_mtime;
> +       dest->i_ctime = src->i_ctime;
> +}
> +
> +static inline void fist_copy_attr_timesizes(struct inode *dest,
> +                                           const struct inode *src)
> +{
> +       dest->i_atime = src->i_atime;
> +       dest->i_mtime = src->i_mtime;
> +       dest->i_ctime = src->i_ctime;
> +       dest->i_size = src->i_size;
> +       dest->i_blocks = src->i_blocks;
> +}
> +
> +static inline void fist_copy_attr_all(struct inode *dest,
> +                                     const struct inode *src)
> +{
> +       dest->i_mode = src->i_mode;
> +       /* we do not need to copy if the file is a deleted file */
> +       if (dest->i_nlink > 0)
> +               dest->i_nlink = get_nlinks(dest);
> +       dest->i_uid = src->i_uid;
> +       dest->i_gid = src->i_gid;
> +       dest->i_rdev = src->i_rdev;
> +       dest->i_atime = src->i_atime;
> +       dest->i_mtime = src->i_mtime;
> +       dest->i_ctime = src->i_ctime;
> +       dest->i_blkbits = src->i_blkbits;
> +       dest->i_size = src->i_size;
> +       dest->i_blocks = src->i_blocks;
> +       dest->i_flags = src->i_flags;
> +}

Ecryptfs has the exact same bits. Please consolidate to common code.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/