linux-kernel - Re: [PATCH 07/18] V4L/DVB (4733): Tda10086: fix frontend selection for dvb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4531287B.5030507@linuxtv.org>
Date:	Sat, 14 Oct 2006 14:12:11 -0400
From:	Michael Krufky <mkrufky@...uxtv.org>
To:	Adrian Bunk <bunk@...sta.de>
CC:	mchehab@...radead.org, linux-kernel@...r.kernel.org,
	linux-dvb-maintainer@...uxtv.org,
	Andrew de Quincey <adq_dvb@...skialf.net>
Subject: Re: [PATCH 07/18] V4L/DVB (4733): Tda10086: fix frontend selection
 for dvb_attach

Adrian Bunk wrote:
> On Sat, Oct 14, 2006 at 09:00:50AM -0300, mchehab@...radead.org wrote:
>> From: Michael Krufky <mkrufky@...uxtv.org>
>>
>> Signed-off-by: Michael Krufky <mkrufky@...uxtv.org>
>> Signed-off-by: Mauro Carvalho Chehab <mchehab@...radead.org>
>> ---
>>
>>  drivers/media/dvb/frontends/tda10086.h |    9 +++++++++
>>  1 files changed, 9 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/media/dvb/frontends/tda10086.h b/drivers/media/dvb/frontends/tda10086.h
>> index e8061db..18457ad 100644
>> --- a/drivers/media/dvb/frontends/tda10086.h
>> +++ b/drivers/media/dvb/frontends/tda10086.h
>> @@ -35,7 +35,16 @@ struct tda10086_config
>>  	u8 invert;
>>  };
>>  
>> +#if defined(CONFIG_DVB_TDA10086) || defined(CONFIG_DVB_TDA10086_MODULE)
>>  extern struct dvb_frontend* tda10086_attach(const struct tda10086_config* config,
>>  					    struct i2c_adapter* i2c);
>> +#else
>> +static inline struct dvb_frontend* tda10086_attach(const struct tda10086_config* config,
>> +						   struct i2c_adapter* i2c)
>> +{
>> +	printk(KERN_WARNING "%s: driver disabled by Kconfig\n", __FUNCTION__);
>> +	return NULL;
>> +}
>> +#endif // CONFIG_DVB_TDA10086
> 
> As already said:
> This breaks with CONFIG_VIDEO_SAA7134_DVB=y, CONFIG_DVB_TDA10086=m.

Again, the breakage is from DVB_FE_CUSTOMIZE=Y, not the above ^^.

This patch must be applied.

-Mike Krufky
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/