linux-kernel - Re: drivers/base/sys.c bug found

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20061014051144.GA17315@suse.de>
Date:	Fri, 13 Oct 2006 22:11:44 -0700
From:	Greg KH <gregkh@...e.de>
To:	Jeff Garzik <jeff@...zik.org>
Cc:	Andrew Morton <akpm@...l.org>, Shaohua Li <shaohua.li@...el.com>,
	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: drivers/base/sys.c bug found

On Wed, Oct 04, 2006 at 07:38:07AM -0400, Jeff Garzik wrote:
> sysdev_driver::add is defined to return an error (as it should), but 
> that error code is never checked.

Ick, good catch.

I hate those sysdev devices...

Hm, in sysdev_driver_register() we don't want to return any error there,
as it doesn't make sense to.

Shaohua, sysdev devices should not stop the notificiation if a single
add() function returns an error, right?  All of the individual drivers
want to be notified of the device.

Bleah...did I mention I don't like these things...

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/