linux-kernel - Re: [PATCH 1/7] Char: stallion, use pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4531EF3A.70101@gmail.com>
Date:	Sun, 15 Oct 2006 10:19:47 +0159
From:	Jiri Slaby <jirislaby@...il.com>
To:	Richard Knutsson <ricknu-0@...dent.ltu.se>
CC:	Andrew Morton <akpm@...l.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/7] Char: stallion, use pr_debug macro

Richard Knutsson wrote:
> Sorry for the late respond, just saw it...
> 
> Jiri Slaby wrote:
>> stallion, use pr_debug macro
>>   
> As it is a driver, is it not recommended to use the "dev_dbg()" found in 
> include/linux/device.h, instead of pr_debug?

Only iff you have access to struct device. And you don't have here, but 2 prints 
in stl_initpcibrd. This would be fixed in next patch serie...

regards,
-- 
http://www.fi.muni.cz/~xslaby/            Jiri Slaby
faculty of informatics, masaryk university, brno, cz
e-mail: jirislaby gmail com, gpg pubkey fingerprint:
B674 9967 0407 CE62 ACC8  22A0 32CC 55C3 39D4 7A7E
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/