linux-kernel - Re: [PATCH 08/18] V4L/DVB (4734): Tda826x: fix frontend selection for dvb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1160877306.28666.21.camel@praia>
Date:	Sat, 14 Oct 2006 22:55:06 -0300
From:	Mauro Carvalho Chehab <mchehab@...radead.org>
To:	Adrian Bunk <bunk@...sta.de>
Cc:	Michael Krufky <mkrufky@...uxtv.org>, linux-kernel@...r.kernel.org,
	linux-dvb-maintainer@...uxtv.org,
	Andrew de Quincey <adq_dvb@...skialf.net>
Subject: Re: [PATCH 08/18] V4L/DVB (4734): Tda826x: fix frontend selection
	for dvb_attach

Em Sáb, 2006-10-14 às 21:14 +0200, Adrian Bunk escreveu:
> On Sat, Oct 14, 2006 at 02:57:10PM -0400, Michael Krufky wrote:
> > Adrian Bunk wrote:
> > 
> > Two separate problems, please do not confuse them.
> > 
> > My tda10086 and tda826x patches are correct -- there is no question of it.
> 
> The problem is that they don't fix the whole problem.
Yes. Trent made two patches using your suggestion of checking for
MODULE. I'll submit it to Linus probably tomorrow after some tests.

If you want to review, they are at:
http://linuxtv.org/hg/v4l-dvb?cmd=changeset;node=b8c06286cb3a;style=gitweb
http://linuxtv.org/hg/v4l-dvb?cmd=changeset;node=18a778dbf540;style=gitweb

> To be honest and after looking deeper at it, I don't like this 
> CONFIG_DVB_FE_CUSTOMIZE approach at all since it adds that much 
> complexity for not much gain.
Yes, it adds some complexity. The gain, however, is to allow having
smaller kernel size on embedded systems and DVR using MythTV or Freevo.
There's a similar feature for V4L (Autoselect pertinent
encoders/decoders and other helper chips), that allows selecting just
the needed stuff. 
> 
> I'd simply select all frontends unconditionally
Most users do this, including me :)

Cheers, 
Mauro.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/