linux-kernel - Re: [Patch 3/3] Driver core: Per-subsystem multithreaded probing.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20061016172631.47d3eb70@gondolin.boeblingen.de.ibm.com>
Date:	Mon, 16 Oct 2006 17:26:31 +0200
From:	Cornelia Huck <cornelia.huck@...ibm.com>
To:	Alan Stern <stern@...land.harvard.edu>
Cc:	Duncan Sands <duncan.sands@...h.u-psud.fr>,
	Greg K-H <greg@...ah.com>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [Patch 3/3] Driver core: Per-subsystem multithreaded probing.

On Mon, 16 Oct 2006 10:59:28 -0400 (EDT),
Alan Stern <stern@...land.harvard.edu> wrote:

> That's not quite true.  You could acquire dev->parent->sem always, just to
> be certain.  

But dev->parent->sem wouldn't be taken in the non-multithreaded path,
so we would change the semantics.

> However USB shouldn't use this form of multithreaded probing
> in any case; it should instead use multiple threads for khubd.

OK, so usb shouldn't request multithreaded probe.

> >  but
> > that still results in bus->remove being called without a prior ->probe
> > (but not drv->probe since dev->driver is not set at that time).
> 
> How so?  We shouldn't call bus->remove if a driver isn't bound.

Eh, yes. I was confused :)

> Some other things were left out of the patch.  Since we can no longer know 
> whether any drivers will get bound at all, device_attach() should now 
> return void.

But device_bind_driver() may still return an error, if creating the
links failed.

-- 
Cornelia Huck
Linux for zSeries Developer
Tel.: +49-7031-16-4837, Mail: cornelia.huck@...ibm.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/