linux-kernel - Re: [PATCH 2.6.19-rc2] scsi: megaraid_{mm,mbox}: 64-bit DMA capability fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1161027285.3433.25.camel@mulgrave.il.steeleye.com>
Date:	Mon, 16 Oct 2006 14:34:44 -0500
From:	James Bottomley <James.Bottomley@...elEye.com>
To:	Vasily Averin <vvs@...ru>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	linux-scsi@...r.kernel.org, "Ju, Seokmann" <Seokmann.Ju@...l.com>,
	Andrew Morton <akpm@...l.org>,
	Linus Torvalds <torvalds@...l.org>, devel@...nvz.org,
	Andrey Mirkin <amirkin@...ru>
Subject: Re: [PATCH 2.6.19-rc2] scsi: megaraid_{mm,mbox}: 64-bit DMA
	capability fix

On Mon, 2006-10-16 at 12:08 +0400, Vasily Averin wrote:
> It is known that 2 LSI Logic MegaRAID SATA RAID Controllers (150-4 and 150-6)
> don't support 64-bit DMA. Unfortunately currently this check is wrong and driver
>  sets 64-bit DMA mode for these devices.
> 
> Signed-off-by:	Andrey Mirkin <amirkin@...ru>
> Ack-by:		Vasily Averin <vvs@...ru>
> 
> --- linux-2.6.19-rc2/drivers/scsi/megaraid/megaraid_mbox.c.mgst6	2006-10-16
> 10:26:50.000000000 +0400
> +++ linux-2.6.19-rc2/drivers/scsi/megaraid/megaraid_mbox.c	2006-10-16
> 11:30:55.000000000 +0400
> @@ -884,7 +884,7 @@ megaraid_init_mbox(adapter_t *adapter)
> 
>  	if (((magic64 == HBA_SIGNATURE_64_BIT) &&
>  		((adapter->pdev->subsystem_device !=
> -		PCI_SUBSYS_ID_MEGARAID_SATA_150_6) ||
> +		PCI_SUBSYS_ID_MEGARAID_SATA_150_6) &&
>  		(adapter->pdev->subsystem_device !=
>  		PCI_SUBSYS_ID_MEGARAID_SATA_150_4))) ||
>  		(adapter->pdev->vendor == PCI_VENDOR_ID_LSI_LOGIC &&

Er ... this patch would apply in reverse, but what's in the tree
currently looks to be correct.

James


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/