linux-kernel - Re: [Patch 3/3] Driver core: Per-subsystem multithreaded probing.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.0610161717120.5813-100000@iolanthe.rowland.org>
Date:	Mon, 16 Oct 2006 17:27:09 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Cornelia Huck <cornelia.huck@...ibm.com>
cc:	Duncan Sands <duncan.sands@...h.u-psud.fr>,
	Greg K-H <greg@...ah.com>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [Patch 3/3] Driver core: Per-subsystem multithreaded probing.

On Mon, 16 Oct 2006, Cornelia Huck wrote:

> > So the question is what do do if someone calls device_register() or
> > device_add() with dev->driver set.  If everything succeeds except for
> > creation of the symlinks, should the device remain registered?  The driver
> > core has been vacillating about this recently.  I'm not sure what the 
> > right answer is.
> 
> If dev->driver has not been set and symlink creation failed, we'll end
> up with an unbound but registered device. Maybe the same should happen
> if dev->driver had been set before (register the device but reset
> dev->driver to NULL)?

That _seems_ reasonable.  But what do subsystem drivers expect?  They
might assume that the binding succeeded whenever the registration 
succeeded.  Although it may not make any real difference in the end.

And of course, we always have the excuse that up until a week ago, failure
to create the symlinks would not cause device registration to fail...

Alan Stern

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/