| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1061016233015.11330@suse.de> Date: Tue, 17 Oct 2006 09:30:15 +1000 From: NeilBrown <neilb@...e.de> To: Andrew Morton <akpm@...l.org> Cc: nfs@...ts.sourceforge.net, linux-kernel@...r.kernel.org Subject: [PATCH 002 of 5] knfsd: nfsd4: fix open permission checking From: "J. Bruce Fields" <bfields@...ldses.org> We weren't actually checking for SHARE_ACCESS_WRITE, with the result that the owner could open a non-writeable file for write! Continue to allow DENY_WRITE only with write access. Thanks to Jim Rees for reporting the bug. Signed-off-by: J. Bruce Fields <bfields@...i.umich.edu> Signed-off-by: Neil Brown <neilb@...e.de> ### Diffstat output ./fs/nfsd/nfs4proc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff .prev/fs/nfsd/nfs4proc.c ./fs/nfsd/nfs4proc.c --- .prev/fs/nfsd/nfs4proc.c 2006-10-17 09:02:26.000000000 +1000 +++ ./fs/nfsd/nfs4proc.c 2006-10-17 09:04:13.000000000 +1000 @@ -78,8 +78,10 @@ do_open_permission(struct svc_rqst *rqst if (open->op_share_access & NFS4_SHARE_ACCESS_READ) accmode |= MAY_READ; - if (open->op_share_deny & NFS4_SHARE_ACCESS_WRITE) + if (open->op_share_access & NFS4_SHARE_ACCESS_WRITE) accmode |= (MAY_WRITE | MAY_TRUNC); + if (open->op_share_deny & NFS4_SHARE_DENY_WRITE) + accmode |= MAY_WRITE; status = fh_verify(rqstp, current_fh, S_IFREG, accmode); - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists