linux-kernel - Re: [PATCH] pata_marvell: Marvell 6101/6145 PATA driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 16 Oct 2006 19:48:41 -0400
From:	Jeff Garzik <jgarzik@...ox.com>
To:	Andrew Morton <akpm@...l.org>
CC:	Alan Cox <alan@...rguk.ukuu.org.uk>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pata_marvell: Marvell 6101/6145 PATA driver

Andrew Morton wrote:
> On Mon, 16 Oct 2006 16:40:06 +0100
> Alan Cox <alan@...rguk.ukuu.org.uk> wrote:
> 
>> +static int marvell_pre_reset(struct ata_port *ap)
>> +{
>> +	struct pci_dev *pdev = to_pci_dev(ap->host->dev);
>> +	u32 devices;
>> +	unsigned long bar5;
>> +	void __iomem *barp;
>> +	int i;
>> +
>> +	/* Check if our port is enabled */
>> +
>> +	bar5 = pci_resource_start(pdev, 5);
>> +	barp = ioremap(bar5, 0x10);
> 
> hm.  pci_resource_start() returns a possibly-64-bit resource_size_t
> nowadays.  But ioremap() doesn't know how to remap such a thing.

These days, pci_iomap() should be used anyway.

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/