lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 16 Oct 2006 01:12:14 +0100 From: Al Viro <viro@....linux.org.uk> To: Marcel Holtmann <marcel@...tmann.org> Cc: Linus Torvalds <torvalds@...l.org>, davem@...emloft.net, linux-kernel@...r.kernel.org Subject: Re: [PATCH 1/4] l2cap endianness annotations On Mon, Oct 16, 2006 at 01:39:03AM +0200, Marcel Holtmann wrote: > > @@ -205,7 +205,7 @@ #define l2cap_pi(sk) ((struct l2cap_pinf > > > > struct l2cap_pinfo { > > struct bt_sock bt; > > - __u16 psm; > > + __le16 psm; > > __u16 dcid; > > __u16 scid; > > > > @@ -221,7 +221,7 @@ struct l2cap_pinfo { > > > > __u8 ident; > > > > - __u16 sport; > > + __le16 sport; > > > > struct l2cap_conn *conn; > > struct sock *next_c; > > These are internal. We should have to annotate them. They should store > it in host order. If not, than that is the problem. BTW, I would leave ->psm is wire order; we compare it to ->l2_psm from sockaddr_l2 a lot, so putting a conversion there looks odd. Note that we do pass ->ls_psm to __l2cap_sock_by_addr(), so I'm not sure if I like the idea of host-endian ->sport; we would need to slap a conversion there as well. See also bacpy(&bt_sk(sk)->src, &la->l2_bdaddr); l2cap_pi(sk)->psm = la->l2_psm; l2cap_pi(sk)->sport = la->l2_psm; sk->sk_state = BT_BOUND; for other place where net-endian gets there. Are you sure that you want both to be switched to host-endian? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists