[<prev] [next>] [day] [month] [year] [list]
Message-ID: <20061017130556.60096290@gondolin.boeblingen.de.ibm.com>
Date: Tue, 17 Oct 2006 13:05:56 +0200
From: Cornelia Huck <cornelia.huck@...ibm.com>
To: Greg K-H <greg@...ah.com>
Cc: Alan Stern <stern@...land.harvard.edu>,
Duncan Sands <duncan.sands@...h.u-psud.fr>,
linux-kernel <linux-kernel@...r.kernel.org>
Subject: [Patch 2/4] Driver core: Change function call order in
device_bind_driver().
From: Cornelia Huck <cornelia.huck@...ibm.com>
Change function call order in device_bind_driver().
If we create symlinks (which might fail) before adding the device to the list
we don't have to clean up afterwards (which we didn't).
Signed-off-by: Cornelia Huck <cornelia.huck@...ibm.com>
---
drivers/base/dd.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
--- linux-2.6.orig/drivers/base/dd.c
+++ linux-2.6/drivers/base/dd.c
@@ -80,8 +80,12 @@ static void driver_sysfs_remove(struct d
*/
int device_bind_driver(struct device *dev)
{
- driver_bound(dev);
- return driver_sysfs_add(dev);
+ int ret;
+
+ ret = driver_sysfs_add(dev);
+ if (!ret)
+ driver_bound(dev);
+ return ret;
}
struct stupid_thread_structure {
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists