[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1161092316.24237.169.camel@localhost.localdomain>
Date: Tue, 17 Oct 2006 14:38:36 +0100
From: Alan Cox <alan@...rguk.ukuu.org.uk>
To: ggaleotti@...erfree.it
Cc: akpm@...l.org, wim@...ana.be, linux-kernel@...r.kernel.org
Subject: Re: [patch 1/1] watchdog driver for Digital-Logic MSM-P5XEN PC104
unit
Ar Maw, 2006-10-17 am 12:34 +0000, ysgrifennodd ggaleotti@...erfree.it:
> +static void
> +wdt_enable(unsigned long data)
> +{
> + (void)data;
> +
> + outb(inb(io_base + WDT_OFFSET) & 0xf7, io_base + WDT_OFFSET);
> +}
> +
If you don't need "data" why pass it ?
No locking against parallel close/open
No no-way-out lock implementation
Short many of the standard ioctls it could and should implement (eg
timeout get)
NAK for now although it just needs tidying and expanding out a little to
be a good driver.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists