linux-kernel - Re: [PATCH] sata_nv ADMA/NCQ support for nForce4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4535032F.2080807@rtr.ca>
Date:	Tue, 17 Oct 2006 12:22:07 -0400
From:	Mark Lord <lkml@....ca>
To:	Robert Hancock <hancockr@...w.ca>
Cc:	Jens Axboe <jens.axboe@...cle.com>,
	Allen Martin <AMartin@...dia.com>,
	Jeff Garzik <jeff@...zik.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	linux-ide@...r.kernel.org, prakash@...noor.de
Subject: Re: [PATCH] sata_nv ADMA/NCQ support for nForce4

Robert Hancock wrote:
> Mark Lord wrote:
>> Robert Hancock wrote:
>>>
>>> +/* ADMA Physical Region Descriptor - one SG segment */
>>> +struct nv_adma_prd {
>>> +    __le64            addr;
>>> +    __le32            len;
>>> +    u8            flags;
>>> +    u8            packet_len;
..
>>> +struct nv_adma_cpb {
>>> +    u8            resp_flags;    //0
>>> +    u8            reserved1;     //1
>>> +    u8            ctl_flags;     //2
>>> +    // len is length of taskfile in 64 bit words
>>> +     u8            len;           //3 +    u8            
>>> tag;           //4
>>> +    u8            next_cpb_idx;  //5
>..
>> Are those CPB / PRD structs endian-safe when using a big-endian CPU?
>>
>> Cheers
> 
> They should be, I believe cpu_to_leXX is used whenever the multi-byte 
> elements are being written. 

I was thinking more about the non wordsized fields,
such as the various u8 bytes that gcc will lay out differently
depending upon endianess.

Cheers

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/