linux-kernel - Re: [PATCH] x86_64: using irq_domain in ioapic_retrigger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <m1d58qan95.fsf@ebiederm.dsl.xmission.com>
Date:	Tue, 17 Oct 2006 11:03:02 -0600
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	"Yinghai Lu" <yinghai.lu@....com>
Cc:	"Andi Kleen" <ak@....de>,
	"linux kernel mailing list" <linux-kernel@...r.kernel.org>,
	yhlu.kernel@...il.com
Subject: Re: [PATCH] x86_64: using irq_domain in ioapic_retrigger_irq

"Yinghai Lu" <yinghai.lu@....com> writes:

> using irq_domain[irq] to get cpu_mask for send_IPI_mask
>
> Signed-off-by: Yinghai Lu <yinghai.lu@....com>

YH I have to grumble at you, your patch suffers from white space damage
and does not apply.

In addition while looking this version is actually broken because
for retrigger irq we only ever want to send the irq once and your
version has the potential to be broadcast to several cpus.  Not
what we want.

I will send a fixed version in a minute.

Eric


>
> diff --git a/arch/x86_64/kernel/io_apic.c b/arch/x86_64/kernel/io_apic.c
> index 44b55f8..6a07bce 100644
> --- a/arch/x86_64/kernel/io_apic.c
> +++ b/arch/x86_64/kernel/io_apic.c
> @@ -1254,13 +1254,12 @@ static unsigned int startup_ioapic_irq(u
> static int ioapic_retrigger_irq(unsigned int irq)
> {
>        cpumask_t mask;
> -       unsigned vector;
> +       int vector;
>
>        vector = irq_vector[irq];
> -       cpus_clear(mask);
> -       cpu_set(vector >> 8, mask);
> +       mask = irq_domain[irq];
>
> -       send_IPI_mask(mask, vector & 0xff);
> +       send_IPI_mask(mask, vector);
>
>        return 1;
> }
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/