linux-kernel - Re: [Patch 4/4] Driver core: Don't fail attaching the device if it cannot be bound.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.0610171542440.3627-100000@iolanthe.rowland.org>
Date:	Tue, 17 Oct 2006 15:43:22 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Cornelia Huck <cornelia.huck@...ibm.com>
cc:	Greg K-H <greg@...ah.com>,
	Duncan Sands <duncan.sands@...h.u-psud.fr>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [Patch 4/4] Driver core: Don't fail attaching the device if it
 cannot be bound.

On Tue, 17 Oct 2006, Cornelia Huck wrote:

> On Tue, 17 Oct 2006 12:04:28 -0400 (EDT),
> Alan Stern <stern@...land.harvard.edu> wrote:

> > It looks odd to test the value of ret when you've just crashed the system 
> > if ret < 0.  You probably should change the BUG_ON to a WARN_ON or 
> > something similar.
> 
> OK, WARN_ON is probably better (but it should never happen anyway).
> Updated patch below.

Yes, I like this one better.

Alan Stern

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/