linux-kernel - Re: 2.6.19-rc2-mm1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <45349744.9040508@ens-lyon.org>
Date:	Tue, 17 Oct 2006 10:41:40 +0200
From:	Brice Goglin <Brice.Goglin@...-lyon.org>
To:	Andrew Morton <akpm@...l.org>
CC:	linux-kernel@...r.kernel.org
Subject: Re: 2.6.19-rc2-mm1

Andrew Morton wrote:
> +add-support-for-the-generic-backlight-device-to-the-ibm-acpi-driver.patch
> +add-support-for-the-generic-backlight-device-to-the-ibm-acpi-driver-fix.patch
> +add-support-for-the-generic-backlight-device-to-the-asus-acpi-driver.patch
> +add-support-for-the-generic-backlight-device-to-the-toshiba-acpi-driver.patch
> +acpi-cpufreq-remove-dead-code.patch
>
>  ACPI things

Hi Andrew,

backlight causes build problems on my T43:

  MODPOST 174 modules
WARNING: "backlight_device_register" [drivers/acpi/ibm_acpi.ko] undefined!
WARNING: "backlight_device_unregister" [drivers/acpi/ibm_acpi.ko] undefined!
make[1]: *** [__modpost] Error 1
make: *** [modules] Error 2

I have ACPI_IBM=m, it selects BACKLIGHT_DEVICE. But, ibm-acpi.ko
actually requires backlight_device_register and _unregister, in
drivers/video/backlight/backlight.c which is compiled when
BACKLIGHT_CLASS_DEVICE is enabled. But, BACKLIGHT_CLASS_DEVICE depends
on BACKLIGHT_LCD_SUPPORT, which I don't have enabled.
Some other ACPI drivers (sony, toshiba, asus and maybe some other
non-ACPI drivers) probably have the same problem.

I don't know what the proper fix is. I don't know whether we want such
ACPI drivers to force BACKLIGHT_CLASS_DEVICE. Maybe we should put the
code in the ACPI drivers inside #ifdef BACKLIGHT_CLASS_DEVICE?

My .config is attached.

Thanks,
Brice

View attachment "config-2.6.19-rc2-mm1" of type "text/plain" (46812 bytes)