linux-kernel - [2.6 patch] fs/gfs2/dir.c:gfs2_dir_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20061019131224.GL3502@stusta.de>
Date:	Thu, 19 Oct 2006 15:12:24 +0200
From:	Adrian Bunk <bunk@...sta.de>
To:	swhiteho@...hat.com
Cc:	cluster-devel@...hat.com, linux-kernel@...r.kernel.org
Subject: [2.6 patch] fs/gfs2/dir.c:gfs2_dir_write_data(): remove dead code

The Coverity checker spotted this obviously dead code.

Signed-off-by: Adrian Bunk <bunk@...sta.de>

--- linux-2.6/fs/gfs2/dir.c.old	2006-10-19 01:07:42.000000000 +0200
+++ linux-2.6/fs/gfs2/dir.c	2006-10-19 01:07:49.000000000 +0200
@@ -209,14 +209,12 @@ static int gfs2_dir_write_data(struct gf
 		if (error)
 			goto fail;
 
 		gfs2_trans_add_bh(ip->i_gl, bh, 1);
 		memcpy(bh->b_data + o, buf, amount);
 		brelse(bh);
-		if (error)
-			goto fail;
 
 		buf += amount;
 		copied += amount;
 		lblock++;
 		dblock++;
 		extlen--;

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/