linux-kernel - Re: Unnecessary BKL contention in video1394

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200610191527.42802.ak@suse.de>
Date:	Thu, 19 Oct 2006 15:27:42 +0200
From:	Andi Kleen <ak@...e.de>
To:	Daniel Drake <ddrake@...ntes3d.com>
Cc:	Stefan Richter <stefanr@...6.in-berlin.de>,
	linux1394-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Subject: Re: Unnecessary BKL contention in video1394


> Adding Andi Kleen to CC, who added the BKL around __video1394_ioctl a
> long while back (when converting video1394 to compat_ioctl).
> 
> I don't feel that any replacement protection is needed, since the
> critical sections (where structures are used both in interrupts and in
> file_operations) are already protected by spinlocks.

Fine by me. I just did it to preserve old semantics because I didn't want
to audit the 1394 locking.  But if you think it's not needed feel free to remove
them.

-andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/