linux-kernel - Re: [PATCH] genhd fix or ide workaround -- choose one

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20061019141606.GA10095@localhost>
Date:	Thu, 19 Oct 2006 18:16:06 +0400
From:	Anton Vorontsov <cbou@...l.ru>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	kernel-discuss@...dhelds.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] genhd fix or ide workaround -- choose one

On Thu, Oct 19, 2006 at 05:33:07PM +0400, Anton Vorontsov wrote:
> On Thu, Oct 19, 2006 at 02:08:32PM +0100, Alan Cox wrote:
> > Ar Iau, 2006-10-19 am 16:25 +0400, ysgrifennodd Anton Vorontsov:
> > > It just happens every time on HP iPaq hx4700. hx4700 have internal CF
> > > slot, which is working via pxa2xx pcmcia driver.
> > 
> > I can't duplicate this with the ide_cs driver and a laptop.
> > 
> > > Have you read comments inside -fix patch? Imho it's obvious that nobody
> > > putting driverfs_device second time, but got it twice.
> > 
> > Its also obvious that it currently works on millions of PC systems and
> > that also needs explaining before any change is made.
> 
> You're right, it needs explanation. Unfortunately I don't have any other
> PCMCIAable devices to find it out. :-/ Though, I'll try to find answers
> in the code.

Okay. Wild guess: you're using 32 bit CardBus (yenta socket?), but hx4700
is using 16 bit PCMCIA (drivers/pcmcia/ds.c). And indeed ds.c calling
device_unregister() which triggers that sequece:
ide_cs.c:ide_detach()
ide_cs.c:ide_release()
ide.c:ide_unregister() <- hang here

I've grep'ed drivers/pcmcia/ for the device_unregister and seems nobody
calling it except drivers/pcmcia/ds.c.

-- Anton (irc: bd2)

p.s. drivers/pcmcia/cardbus.c states:
 * cardbus.c -- 16-bit PCMCIA core support

typo?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/