linux-kernel - Re: Unnecessary BKL contention in video1394

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1161271861.2845.12.camel@systems03.lan.brontes3d.com>
Date:	Thu, 19 Oct 2006 11:31:01 -0400
From:	Daniel Drake <ddrake@...ntes3d.com>
To:	Stefan Richter <stefanr@...6.in-berlin.de>
Cc:	Andi Kleen <ak@...e.de>, linux1394-devel@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org
Subject: Re: Unnecessary BKL contention in video1394

On Thu, 2006-10-19 at 16:36 +0200, Stefan Richter wrote:
> Thanks for the info. Daniel, do you want to resend a signed-off patch?
> And __video1394_ioctl and its wrapper video1394_ioctl can certainly be
> merged then.

Yep, I had already made that change locally. I will run it overnight on
several cameras just to be sure, and will send a patch tomorrow.

I also did some more investigation and straightened out my knowledge of
file_operations: release() can never be called while inside a read() or
ioctl(): This would imply that separate threads are in use, and the
driver's release() function is not called until *all* threads have
closed the fd.  In other words I'm now much more confident that this
patch is not removing any necessary locking.

Daniel

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/