linux-kernel - Re: [KJ] [PATCH] Replaced tty->driver_data lines with pci_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20061019191953.GL2602@parisc-linux.org>
Date:	Thu, 19 Oct 2006 13:19:53 -0600
From:	Matthew Wilcox <matthew@....cx>
To:	David KOENIG <karhudever@...il.com>
Cc:	linux-kernel@...r.kernel.org, kernel-janitors@...ts.osdl.org
Subject: Re: [KJ] [PATCH] Replaced tty->driver_data lines with pci_get_drvdata(tty);

On Thu, Oct 19, 2006 at 12:02:59PM -0700, David KOENIG wrote:
> +++ b/fs/compat_ioctl.c
> @@ -1270,7 +1270,7 @@ static int do_kdfontop_ioctl(unsigned in
>  		return -EPERM;
>  	op.data = compat_ptr(((struct console_font_op32 *)&op)->data);
>  	op.flags |= KD_FONT_FLAG_OLD;
> - -	vc = ((struct tty_struct *)file->private_data)->driver_data;
> +	vc = pci_get_drvdata((struct tty_struct *)file->private_data);

Did you even compile this?  pci_get_drvdata doesn't take a struct
tty_struct *, it takes a struct pci_dev *.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/