[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1161290229.8946.51.camel@farscape>
Date: Thu, 19 Oct 2006 15:37:09 -0500
From: Will Schmidt <will_schmidt@...t.ibm.com>
To: Christoph Lameter <clameter@....com>
Cc: Anton Blanchard <anton@...ba.org>, akpm@...l.org,
linuxppc-dev@...abs.org, Paul Mackerras <paulus@...ba.org>,
linux-kernel@...r.kernel.org
Subject: Re: kernel BUG in __cache_alloc_node at
linux-2.6.git/mm/slab.c:3177!
On Thu, 2006-19-10 at 10:03 -0700, Christoph Lameter wrote:
> I would expect this patch to fix your issues. This will allow fallback
> allocations to occur in the page allocator during slab bootstrap. This
> means your per node queues will be contaminated as they were before. After
> the slab allocator is fully booted then the per node queues will become
> gradually become node clean.
>
> I think it would be better if the PPC arch would fix this issue
> by either making memory available on node 0 or setting up node 1 as
> the boot node.
>
This didnt fix the problem on my box. I tried this both against mm and
linux-2.6.git
> Signed-off-by: Christoph Lameter <clameter@....com>
>
> Index: linux-2.6.19-rc2-mm1/mm/slab.c
> ===================================================================
> --- linux-2.6.19-rc2-mm1.orig/mm/slab.c 2006-10-19 11:54:24.000000000 -0500
> +++ linux-2.6.19-rc2-mm1/mm/slab.c 2006-10-19 11:59:24.208194796 -0500
> @@ -1589,7 +1589,10 @@ static void *kmem_getpages(struct kmem_c
> * the needed fallback ourselves since we want to serve from our
> * per node object lists first for other nodes.
> */
> - flags |= cachep->gfpflags | GFP_THISNODE;
> + if (g_cpucache_up != FULL)
> + flags |= cachep->gfpflags;
> + else
> + flags |= cachep->gfpflags | GFP_THISNODE;
>
> page = alloc_pages_node(nodeid, flags, cachep->gfporder);
> if (!page)
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@...abs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists