linux-kernel - Re: [PATCH 1/2] VFS: Make d_materialise_unique() enforce directory uniqueness

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1161291638.5506.9.camel@lade.trondhjem.org>
Date:	Thu, 19 Oct 2006 17:00:38 -0400
From:	Trond Myklebust <Trond.Myklebust@...app.com>
To:	Miklos Szeredi <miklos@...redi.hu>
Cc:	torvalds@...l.org, viro@....linux.org.uk,
	linux-kernel@...r.kernel.org, nfs@...ts.sourceforge.net
Subject: Re: [PATCH 1/2] VFS: Make d_materialise_unique() enforce directory
	uniqueness

On Thu, 2006-10-19 at 22:51 +0200, Miklos Szeredi wrote:
> > From: Trond Myklebust <Trond.Myklebust@...app.com>
> > 
> > If the caller tries to instantiate a directory using an inode that already
> > has a dentry alias, then we attempt to rename the existing dentry instead
> > of instantiating a new one. Fail with an ELOOP error if the rename would
> > affect one of our parent directories.
> > 
> > This behaviour is needed in order to avoid issues such as
> > 
> >   http://bugzilla.kernel.org/show_bug.cgi?id=7178
> >
> 
> This looks like a stale patch.  You posted one on -fsdevel that did
> i_mutex locking as well.

Argh! Thanks for spotting that Miklos... I had forgotten to update my
'fixes' stgit branch with the newer version. Please discard the previous
version of this patch, Linus. I'll resend...

Cheers,
  Trond
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/