linux-kernel - [PATCH] cpuset: minor code refinements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Thu, 19 Oct 2006 02:21:50 -0700
From:	Paul Jackson <pj@....com>
To:	Andrew Morton <akpm@...l.org>
Cc:	Martin Bligh <mbligh@...gle.com>, Paul Menage <menage@...gle.com>,
	Simon.Derr@...l.net, linux-kernel@...r.kernel.org,
	Dinakar Guniguntala <dino@...ibm.com>,
	Rohit Seth <rohitseth@...gle.com>, Robin Holt <holt@....com>,
	dipankar@...ibm.com, Nick Piggin <nickpiggin@...oo.com.au>,
	Paul Jackson <pj@....com>,
	"Siddha, Suresh B" <suresh.b.siddha@...el.com>
Subject: [PATCH] cpuset: minor code refinements

From: Paul Jackson <pj@....com>

A couple of minor code simplifications to the
kernel/cpuset.c code.  No functional change.
Just a little less code and a little more readable.

Signed-off-by: Paul Jackson <pj@....com>

---
 kernel/cpuset.c |    9 ++++-----
 1 files changed, 4 insertions(+), 5 deletions(-)

--- 2.6.19-rc1-mm1.orig/kernel/cpuset.c	2006-10-19 01:06:29.000000000 -0700
+++ 2.6.19-rc1-mm1/kernel/cpuset.c	2006-10-19 01:06:49.000000000 -0700
@@ -729,9 +729,11 @@ static int validate_change(const struct 
 	}
 
 	/* Remaining checks don't apply to root cpuset */
-	if ((par = cur->parent) == NULL)
+	if (cur == &top_cpuset)
 		return 0;
 
+	par = cur->parent;
+
 	/* We must be a subset of our parent cpuset */
 	if (!is_cpuset_subset(trial, par))
 		return -EACCES;
@@ -1060,10 +1062,7 @@ static int update_flag(cpuset_flagbits_t
 	cpu_exclusive_changed =
 		(is_cpu_exclusive(cs) != is_cpu_exclusive(&trialcs));
 	mutex_lock(&callback_mutex);
-	if (turning_on)
-		set_bit(bit, &cs->flags);
-	else
-		clear_bit(bit, &cs->flags);
+	cs->flags = trialcs.flags;
 	mutex_unlock(&callback_mutex);
 
 	if (cpu_exclusive_changed)

-- 
                  I won't rest till it's the best ...
                  Programmer, Linux Scalability
                  Paul Jackson <pj@....com> 1.925.600.0401
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/