linux-kernel - Re: dealing with excessive includes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 20 Oct 2006 09:13:02 -0700
From:	Randy Dunlap <rdunlap@...otime.net>
To:	Stefan Richter <stefanr@...6.in-berlin.de>
Cc:	Al Viro <viro@....linux.org.uk>,
	Linus Torvalds <torvalds@...l.org>,
	Alexey Dobriyan <adobriyan@...il.com>,
	linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org
Subject: Re: dealing with excessive includes

On Fri, 20 Oct 2006 11:26:58 +0200 Stefan Richter wrote:

> Randy Dunlap wrote:
> > Here's about half of checking includers of linux/smp_lock.h to see
> > if they actually use any of its interfaces.  (most don't)
> > 
> > Yet to do:  fs/* and arch/*
> > Built only on x86_64.
> [...]
> >  drivers/acpi/osl.c                            |    1 -
> >  drivers/block/acsi_slm.c                      |    1 -
> >  drivers/block/umem.c                          |    1 -
> >  drivers/char/ds1620.c                         |    1 -
> >  drivers/char/dsp56k.c                         |    1 -
> >  drivers/char/dtlk.c                           |    1 -
> >  drivers/char/ec3104_keyb.c                    |    1 -
> >  drivers/char/ftape/zftape/zftape-init.c       |    1 -
> >  drivers/char/hangcheck-timer.c                |    1 -
> >  drivers/char/ip27-rtc.c                       |    1 -
> >  drivers/char/lp.c                             |    1 -
> >  drivers/char/mem.c                            |    1 -
> >  drivers/char/mxser.c                          |    1 -
> >  drivers/char/ppdev.c                          |    1 -
> >  drivers/char/sysrq.c                          |    1 -
> >  drivers/char/vc_screen.c                      |    1 -
> >  drivers/char/watchdog/omap_wdt.c              |    1 -
> >  drivers/char/watchdog/pcwd_usb.c              |    1 -
> >  drivers/i2c/busses/scx200_acb.c               |    1 -
> >  drivers/i2c/i2c-dev.c                         |    1 -
> >  drivers/ieee1394/raw1394.c                    |    1 -
> >  drivers/infiniband/ulp/iser/iser_verbs.c      |    1 -
> >  drivers/input/evdev.c                         |    1 -
> >  drivers/input/input.c                         |    1 -
> [... etc. pp. ...]
> >  sound/oss/swarm_cs4297a.c                     |    1 -
> >  sound/oss/trident.c                           |    1 -
> >  sound/oss/via82cxxx_audio.c                   |    1 -
> >  166 files changed, 166 deletions(-)
> [...]
> 
> I am afraid in many of these cases a proper cleanup would _replace_ the
> include by the correct one, not just delete it. For example,
> drivers/ieee1394/raw1394.c should include linux/spinlock.h. AFAICS it
> does so at the moment only indirectly via another header.

I don't think that we can fix it all at once.  This is just one step.
AFAICT for raw1394.c, it's not incorrect as is, but more is needed,
sure.

Yes, we have lots of header include indirection going on.
I don't know of a good tool to detect/fix it.

What Al is doing is good stuff, but I'd still prefer to see an even
better tool, like gcc-preprocessor or sparse based (I guess).

---
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/