linux-kernel - Re: Badness in irq_create_mapping at arch/powerpc/kernel/irq.c:527

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 20 Oct 2006 11:47:49 +1000
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
Cc:	Nicolas DET <nd@...an-gmbh.de>, linuxppc-dev@...abs.org,
	Olaf Hering <olaf@...fle.de>, linux-kernel@...r.kernel.org
Subject: Re: Badness in irq_create_mapping at arch/powerpc/kernel/irq.c:527

Hi Ben,

On Fri, 20 Oct 2006 11:37:01 +1000 Benjamin Herrenschmidt <benh@...nel.crashing.org> wrote:
>
> Index: linux-cell/arch/powerpc/sysdev/i8259.c
> ===================================================================
> --- linux-cell.orig/arch/powerpc/sysdev/i8259.c	2006-10-09 12:03:33.000000000 +1000
> +++ linux-cell/arch/powerpc/sysdev/i8259.c	2006-10-20 11:32:07.000000000 +1000
> @@ -13,6 +13,7 @@
>  #include <linux/interrupt.h>
>  #include <linux/kernel.h>
>  #include <linux/delay.h>
> +#include <linux/module.h>
>  #include <asm/io.h>
>  #include <asm/i8259.h>
>  #include <asm/prom.h>
> @@ -224,6 +225,12 @@ static struct irq_host_ops i8259_host_op
>  	.xlate = i8259_host_xlate,
>  };
>
> +struct irq_host *i8259_get_host(void)
> +{
> +	return i8259_host;
> +}
> +EXPORT_SYMBOL(i8259_get_host);

Surely it doesn't need exporting is its only caller is in
arch/powerpc/platforms/chrp/setup.c?

--
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au
http://www.canb.auug.org.au/~sfr/

Content of type "application/pgp-signature" skipped