| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 20 Oct 2006 23:01:29 +0200 From: Andi Kleen <ak@...e.de> To: Stephen Hemminger <shemminger@...l.org> Cc: David Miller <davem@...emloft.net>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 2/3] netpoll: rework skb transmit queue > But, it also violates the assumptions of the network devices. > It calls NAPI poll back with IRQ's disabled and potentially doesn't > obey the semantics about only running on the same CPU as the > received packet. netpoll always played a little fast'n'lose with various locking rules. Also often inside the drivers are a little sloppy in the poll path. That's fine for getting an oops out, but risky for normal kernel messages when the driver must be still working afterwards. The standard console code makes this conditional on oops_in_progress - it breaks locks when true and otherwise it follows the safe approach. Perhaps it would be better to use different paths in netconsole too depending on whether oops_in_progress is true or not. e.g. if !oops_in_progress (use the standard output path) else use current path. That would avoid breaking the driver during normal operation and also have the advantage that the normal netconsole messages would go through the queueing disciplines etc. -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists