linux-kernel - Re: [PATCH] Minor fixes to generic do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20061020053638.GS2602@parisc-linux.org>
Date:	Thu, 19 Oct 2006 23:36:38 -0600
From:	Matthew Wilcox <matthew@....cx>
To:	Andrew Morton <akpm@...l.org>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Minor fixes to generic do_div

On Thu, Oct 19, 2006 at 09:59:54PM -0700, Andrew Morton wrote:
> Can we use typecheck(), from include/linux/kernel.h?

I don't know.

It's copied and pasted from down below, so possibly this was
intentionally not used.  or possibly the author didn't know about
typecheck().

If we do use it, we either have to include linux/kernel.h in
asm-generic/div64.h, which drags in a slew of includes of its own, or be
sure that all users already include kernel.h.  i bet they do.

My allmodconfig build is currently testing out the
remove-sched.h-from-asm-parisc-uaccess.h patch based on viro's x86-64
patch seen earlier today, so I won't be testing the second hypothesis
tonight.  Anyone want to try plugging in typecheck() and seeing if
anything breaks?  NB: you'll want to be sure your arch is using
asm-generic/div64, or add the typecheck() to your arch's
asm-foo/div64.h.

We should probably do that anyway, at least for i386.  And then someone
else would maybe wonder what the xtensa port is up to.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/