linux-kernel - Re: [PATCH 2/3] netpoll: rework skb transmit queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20061020.001530.35664340.davem@davemloft.net>
Date:	Fri, 20 Oct 2006 00:15:30 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	shemminger@...l.org
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] netpoll: rework skb transmit queue

From: Stephen Hemminger <shemminger@...l.org>
Date: Thu, 19 Oct 2006 10:15:43 -0700

> The original skb management for netpoll was a mess, it had two queue paths
> and a callback. This changes it to have a per-instance transmit queue
> and use a tasklet rather than a work queue for the congested case.
> 
> Signed-off-by: Stephen Hemminger <shemminger@...l.org>

I think you mis-diffed this one:

- 	WARN_ON(skb->protocol == 0);

That line doesn't exist in my copy of net/core/netpoll.c
even with your first patch applied.

Also, you forgot to remove the ->drop callback pointer
from struct netpoll, which you should do if it really
isn't used any more.

I think you might run into problems there, as I believe the netdump
stuff does make non-trivial use of the ->drop callback.  Indeed, it
uses the ->dump callback for invoking a special
netpoll_start_netdump() function.  I'm pretty sure ->dump was created
specifically to accomodate netdump.

So this is something else which will need to be worked out before we
can apply this patch.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/