linux-kernel - Re: [PATCH] x86_64 add missing enter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200610211522.53938.ak@suse.de>
Date:	Sat, 21 Oct 2006 15:22:53 +0200
From:	Andi Kleen <ak@...e.de>
To:	eranian@....hp.com
Cc:	linux-kernel@...r.kernel.org, akpm@...l.org
Subject: Re: [PATCH] x86_64 add missing enter_idle() calls


> I finally found the culprit for this. The current code is wrong for the
> simple reason that the cpu_idle() function is NOT always the lowest level
> idle loop function. For enter_idle()/__exit_idle() to work correctly they
> must be placed in the lowest-level idle loop. The cpu_idle() eventually ends
> up in the idle() function, but this one may have a loop in it! This is the
> case when idle()=cpu_default_idle() and idle()=poll_idle(), for instance. 

Ah now I remember - i had actually fixed that (it was the cleanup-idle-loops
patch) that moved the loops one level up. But then I disabled the patch
at the request of Andrew because it conflicted with some ACPI idle changes.

I'll readd it for .20, then things should be ok.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/