linux-kernel - Re: [PATCH] [11/19] i386: Fix fake return address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <453A6320.30009@goop.org>
Date:	Sat, 21 Oct 2006 11:12:48 -0700
From:	Jeremy Fitzhardinge <jeremy@...p.org>
To:	Andi Kleen <ak@...e.de>
CC:	Andi Kleen <ak@....de>, Andrew Morton <akpm@...l.org>,
	patches@...-64.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [11/19] i386: Fix fake return address

Andi Kleen wrote:
> From: Jeremy Fitzhardinge <jeremy@...p.org>
> The fake return address was being set to __KERNEL_PDA, rather than 0.
> Push it earlier while %eax still equals 0.
>
> Signed-off-by: Jeremy Fitzhardinge <jeremy@...source.com>
> Signed-off-by: Andi Kleen <ak@...e.de>
> Cc: Andi Kleen <ak@....de>
> Cc: Andrew Morton <akpm@...l.org>
>
> ---
>  arch/i386/kernel/head.S |    2 +-
>  1 files changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux/arch/i386/kernel/head.S
> ===================================================================
> --- linux.orig/arch/i386/kernel/head.S
> +++ linux/arch/i386/kernel/head.S
> @@ -317,7 +317,7 @@ is386:	movl $2,%ecx		# set MP
>  	movl %eax,%gs
>  	lldt %ax
>  	cld			# gcc2 wants the direction flag cleared at all times
> -	pushl %eax		# fake return address
> +	pushl $0		# fake return address for unwinder
>  #ifdef CONFIG_SMP
Yep, that's better than my patch, but the comment is out of date.

    J

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/