linux-kernel - Re: [PATCH] pata_marvell: switch to pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 21 Oct 2006 15:51:40 -0400
From:	Jeff Garzik <jgarzik@...ox.com>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
CC:	akpm@...l.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pata_marvell: switch to pci_iomap as Jeff asked

Alan Cox wrote:
> Signed-off-by: Alan Cox <alan@...hat.com>
> 
> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.19-rc2-mm1/drivers/ata/pata_marvell.c linux-2.6.19-rc2-mm1/drivers/ata/pata_marvell.c
> --- linux.vanilla-2.6.19-rc2-mm1/drivers/ata/pata_marvell.c	2006-10-18 13:51:02.000000000 +0100
> +++ linux-2.6.19-rc2-mm1/drivers/ata/pata_marvell.c	2006-10-18 13:56:55.000000000 +0100
> @@ -20,7 +20,7 @@
>  #include <linux/ata.h>
>  
>  #define DRV_NAME	"pata_marvell"
> -#define DRV_VERSION	"0.0.4t"
> +#define DRV_VERSION	"0.0.5t"
>  
>  /**
>   *	marvell_pre_reset	-	check for 40/80 pin
> @@ -39,18 +39,17 @@
>  
>  	/* Check if our port is enabled */
>  
> -	bar5 = pci_resource_start(pdev, 5);
> -	barp = ioremap(bar5, 0x10);
> +	barp = pci_ioremap(pdev, 5, 0x10);

Please provide code that links successfully, and compiles without 
obvious warnings.  pci_ioremap() does not exist; you wanted pci_iomap().

I applied the patch, fixed the obvious bugs, and then did my own line 
length, trailing whitespace, "if(" javaism, 'case' indentation, and 
other cosmetic cleanups.

	Jeff




View attachment "patch" of type "text/plain" (3173 bytes)