linux-kernel - Re: [PATCH 01 of 23] VFS: change struct file to use struct path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 21 Oct 2006 03:28:07 -0400
From:	Josef Sipek <jsipek@....cs.sunysb.edu>
To:	Andrew Morton <akpm@...l.org>
Cc:	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	torvalds@...l.org, viro@....linux.org.uk, hch@...radead.org,
	jack@...e.cz
Subject: Re: [PATCH 01 of 23] VFS: change struct file to use struct path

On Sat, Oct 21, 2006 at 12:22:00AM -0700, Andrew Morton wrote:
> On Sat, 21 Oct 2006 02:17:26 -0400
> Josef "Jeff" Sipek <jsipek@...sunysb.edu> wrote:
> 
> > From: Josef "Jeff" Sipek <jsipek@...sunysb.edu>
> > 
> > This patch changes struct file to use struct path instead of having
> > independent pointers to struct dentry and struct vfsmount, and converts all
> > users of f_{dentry,vfsmnt} in fs/ to use f_path.{dentry,mnt}.
> > 
> 
> why?

It's little cleaner than having two pointers. In general, there is a number
of users of dentry-vfsmount pairs in the kernel, and struct path nicely
wraps it.

As to why struct file in particular, and not some other structure, it's
mostly because Al suggested it... "I can give you a dozen examples of
possible users right now - starting with struct file" (from the struct path
thread few days ago.)

Josef "Jeff" Sipek.

-- 
Don't drink and derive. Alcohol and algebra don't mix.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/