[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <m3vemcdz79.fsf@telia.com>
Date: 22 Oct 2006 19:42:34 +0200
From: Peter Osterlund <petero2@...ia.com>
To: balagi@...tmail.de
Cc: linux-kernel@...r.kernel.org, akpm@...l.org
Subject: Re: [PATCH] 2.6.19-rc2-mm2 pktcdvd: add sysfs and debugfs interface
"Thomas Maier" <balagi@...tmail.de> writes:
> this patch adds a sysfs and debugfs interface
> to the pktcdvd driver.
> The procfs interface is not modified!
Calling the character device interface "procfs interface" is
misleading, so I disagree with this part of the patch:
+ Note: pktsetup uses the pktcdvd procfs interface!
The only connection pktsetup has with procfs is that it reads the
character device minor number from /proc/misc. If that number was
available somewhere else or if udev created /dev/pktcdvd/control
automatically, pktsetup wouldn't need /proc at all.
Actually, checking my FC5 installation, /dev/pktcdvd/control is
created automatically when the driver is loaded, so the /proc code in
pktsetup is only needed to cope with older distributions.
--
Peter Osterlund - petero2@...ia.com
http://web.telia.com/~u89404340
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists