linux-kernel - Re: [PATCH 1/7] KVM: userspace interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <453B2863.4060106@qumranet.com>
Date:	Sun, 22 Oct 2006 10:14:27 +0200
From:	Avi Kivity <avi@...ranet.com>
To:	Steven Rostedt <rostedt@...dmis.org>
CC:	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/7] KVM: userspace interface

Steven Rostedt wrote:
>> +
>> +/* for KVM_GET_REGS and KVM_SET_REGS */
>> +struct kvm_regs {
>> +    /* in */
>> +    __u32 vcpu;
>> +    __u32 padding;
>> +
>> +    /* out (KVM_GET_REGS) / in (KVM_SET_REGS) */
>> +    __u64 rax, rbx, rcx, rdx;
>> +    __u64 rsi, rdi, rsp, rbp;
>> +    __u64 r8,  r9,  r10, r11;
>> +    __u64 r12, r13, r14, r15;
>> +    __u64 rip, rflags;
>> +};
>> +
>>     
>
> I know this is for userspace too, but still. Shouldn't this be in
> include/asm-x86_64 and not include/linux.
>   

Most of this file is arch-independent and could be used for other 
virtualization-capable architectures.  I could this snippet to 
asm-x86_64 but where would it leave i386?

(i386 needs access to 64-bit registers since we support 64-bit guests on 
a 64-bit host with a 32-bit userspace)

-- 
error compiling committee.c: too many arguments to function

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/