linux-kernel - [PATCH] [4th RESEND] Remove logic error in /Documentation/devices.txt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1161537893.3657.4.camel@mflaptop>
Date:	Sun, 22 Oct 2006 13:24:53 -0400
From:	Marcus Fischer <marcus-fischer@....de>
To:	linux-kernel@...r.kernel.org
Cc:	gregkh@...e.de
Subject: [PATCH] [4th RESEND]  Remove logic error in
	/Documentation/devices.txt

Hello all,

can someone please tell me what I'm doing wrong with this commit?
I'm lacking experience, but I thought I understood the process correct.

Please send me some feedback that I can rework/modify the patch if required.


Thanks,
Marcus

PS: Please CC me, I'm not on this list.



commit 51f3fe947923f6e775031cc1d538de6cf06ec77d
Author: Marcus Fischer <linux@...cusfischer.com>
Date:   Fri Sep 29 23:50:01 2006 +0200

    I found an logic error in the following commit:
    
        author    Steven Haigh <netwiz@....id.au>
                  Tue, 8 Aug 2006 21:42:06 +0000 (07:42 +1000)
        committer Greg Kroah-Hartman <gregkh@...e.de>
                  Wed, 27 Sep 2006 18:58:59 +0000 (11:58 -0700)
        commit    03270634e242dd10cc8569d31a00659d25b2b8e7
        tree      8f4665eb7b17386e733fcdc7d02e87c4a1592550
        parent    8ac283ad415358f022498887811c35ac656b5222
    
Documentation/devices.txt may either say 
../adutux10 11th OntrackADU device    or 
../adutux9 10th Ontrack ADU device.

Anyway, the original one makes no sense:
   
+ 67 = /dev/usb/adutux0 1st Ontrak ADU device
+ ...
+ 76 = /dev/usb/adutux10 10th Ontrak ADU device

This patch removes the logic error.

However, I saw that MAX_DEVICES is 16.
Thus, shouldn't this docu then say:
"81 = /dev/usb/adutux15 16th Ontrack ADU device" ?

Best,
Marcus



Signed-off-by: Marcus Fischer <linux@...cusfischer.com>
---

diff --git a/Documentation/devices.txt b/Documentation/devices.txt
index addc67b..37efae8 100644
--- a/Documentation/devices.txt
+++ b/Documentation/devices.txt
@@ -2545,7 +2545,7 @@ Your cooperation is appreciated.
66 = /dev/usb/cpad0 Synaptics cPad (mouse/LCD)
67 = /dev/usb/adutux0 1st Ontrak ADU device
    ...
- 76 = /dev/usb/adutux10 10th Ontrak ADU device
+ 76 = /dev/usb/adutux9 10th Ontrak ADU device
96 = /dev/usb/hiddev0 1st USB HID device
    ...
111 = /dev/usb/hiddev15 16th USB HID device



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/