linux-kernel - Re: dealing with excessive includes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0610231003240.3962@g5.osdl.org>
Date:	Mon, 23 Oct 2006 10:05:43 -0700 (PDT)
From:	Linus Torvalds <torvalds@...l.org>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
cc:	Andi Kleen <ak@...e.de>, Randy Dunlap <rdunlap@...otime.net>,
	Stefan Richter <stefanr@...6.in-berlin.de>,
	Al Viro <viro@....linux.org.uk>,
	Alexey Dobriyan <adobriyan@...il.com>,
	Linux Kernel Development <linux-kernel@...r.kernel.org>,
	linux-arch@...r.kernel.org
Subject: Re: dealing with excessive includes

On Mon, 23 Oct 2006, Geert Uytterhoeven wrote:
> 
> I agree _verifying_ this for all config and arch combinations is hard.
> But my point is that right now we're `solving' this at the user (of the
> include) level, which is an order of magnitude more work.
> If the includes were (sufficiently) self-contained, the driver writers would
> have to care less about config/arch dependencies.

But header files already basically are self-contained. They didn't always 
use to be that way, but over the years, we've generally made them that way 
in almost all cases.

The problem is generally not that they aren't self-contained, it's that 
they bring in other things depending on architecture, and then some driver 
depends on a header file including other header files, even when that 
isn't always the case at all: exactly because which header file it 
includes depends on config options (to a small degree) and on architecture 
(to a much larger degree).

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/