linux-kernel - Re: 2.6.19-rc2-mm2: reproducible hang on shutdown on i386

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20061023103448.7c35063b.akpm@osdl.org>
Date:	Mon, 23 Oct 2006 10:34:48 -0700
From:	Andrew Morton <akpm@...l.org>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: 2.6.19-rc2-mm2: reproducible hang on shutdown on i386

> On Mon, 23 Oct 2006 16:43:31 +0200 "Rafael J. Wysocki" <rjw@...k.pl> wrote:
> On Saturday, 21 October 2006 19:30, Rafael J. Wysocki wrote:
> > On Friday, 20 October 2006 10:56, Andrew Morton wrote:
> > > 
> > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.19-rc2/2.6.19-rc2-mm2/
> > > 
> > > - Added the IOAT tree as git-ioat.patch (Chris Leech)
> > > 
> > > - I worked out the git magic to make the wireless tree work
> > >   (git-wireless.patch).  Hopefully it will be in -mm more often now.
> > 
> > [Margin note: bcm43xx doesn't work on my test boxes although it used to on one
> > of them, but I have to play with it a bit more.]
> > 
> > It looks like i386 cannot shut down cleanly with this kernel.  On my test
> > boxes (2 of them) it hangs after killing all processes, 100% of the time.
> 
> I've carried out a binary search which shows that
> 
> add-process_session-helper-routine-deprecate-old-field-fix-warnings.patch
> 
> causes this to happen.

Thanks.  That patch had one bug - this will hopefully fi things up:

From: Jeff Dike <jdike@...toit.com>

add-process_session-helper-routine-deprecate-old-field-fix-warnings.patch
in -mm causes UML to hang at shutdown - init is sitting in a select on the
initctl socket.

This patch fixes it for me.

Signed-off-by: Jeff Dike <jdike@...toit.com>
Cc: Cedric Le Goater <clg@...ibm.com>
Signed-off-by: Andrew Morton <akpm@...l.org>
---

 fs/proc/array.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff -puN fs/proc/array.c~add-process_session-helper-routine-deprecate-old-field-fix-warnings-fix fs/proc/array.c
--- a/fs/proc/array.c~add-process_session-helper-routine-deprecate-old-field-fix-warnings-fix
+++ a/fs/proc/array.c
@@ -388,7 +388,7 @@ static int do_task_stat(struct task_stru
 			stime = cputime_add(stime, sig->stime);
 		}
 
-		signal_session(sig);
+		sid = signal_session(sig);
 		pgid = process_group(task);
 		ppid = rcu_dereference(task->real_parent)->tgid;
 
_

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/