linux-kernel - Re: [PATCH 8/13] KVM: vcpu execution loop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 23 Oct 2006 22:16:13 +0200
From:	Avi Kivity <avi@...ranet.com>
To:	Arnd Bergmann <arnd@...db.de>
CC:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 8/13] KVM: vcpu execution loop

Arnd Bergmann wrote:
> On Monday 23 October 2006 15:30, Avi Kivity wrote:
>   
>> +       asm (
>> +               /* Store host registers */
>> +               "pushf \n\t"
>> +#ifdef __x86_64__
>> +               "push %%rax; push %%rbx; push %%rdx;"
>> +               "push %%rsi; push %%rdi; push %%rbp;"
>> +               "push %%r8;  push %%r9;  push %%r10; push %%r11;"
>> +               "push %%r12; push %%r13; push %%r14; push %%r15;"
>> +               "push %%rcx \n\t"
>> +               "vmwrite %%rsp, %2 \n\t"
>> +#else
>> +               "pusha; push %%ecx \n\t"
>> +               "vmwrite %%esp, %2 \n\t"
>> +#endif
>> +               /* Check if vmlaunch of vmresume is needed */
>> +               "cmp $0, %1 \n\t"
>> +               /* Load guest registers.  Don't clobber flags. */
>> +#ifdef __x86_64__
>> +               "mov %c[cr2](%3), %%rax \n\t"
>> +               "mov %%rax, %%cr2 \n\t"
>> +               "mov %c[rax](%3), %%rax \n\t"
>> +               "mov %c[rbx](%3), %%rbx \n\t"
>> +               "mov %c[rdx](%3), %%rdx \n\t"
>> +               "mov %c[rsi](%3), %%rsi \n\t"
>> +               "mov %c[rdi](%3), %%rdi \n\t"
>> +               "mov %c[rbp](%3), %%rbp \n\t"
>> ...
>>     
>
> This looks like you should simply put it into a .S file.
>
>   

Then I lose all the offsetof constants down the line.  Sure, I could do 
the asm-offsets dance but it seems to me like needless obfuscation.



-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/