lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 22 Oct 2006 20:42:20 -0700 (PDT) From: David Miller <davem@...emloft.net> To: shemminger@...l.org Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 1/3] netpoll: use sk_buff_head for txq From: Stephen Hemminger <shemminger@...l.org> Date: Fri, 20 Oct 2006 15:30:27 -0700 > + spin_lock_irqsave(&netpoll_txq.lock, flags); > + for (skb = (struct sk_buff *)netpoll_txq.next; > + skb != (struct sk_buff *)&netpoll_txq; skb = next) { > + next = skb->next; > + if (skb->dev == dev) > + skb_unlink(skb, &netpoll_txq); > + } > + spin_unlock_irqrestore(&netpoll_txq.lock, flags); > } All SKBs removed here will be leaked, nothing frees them up. Since #2 and #3 depend upon this patch, I'll hold off on those until you fix this bug. Thanks. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists