linux-kernel - Re: [PATCH] Fix use of uninitialized variable in drivers/video/sis/init301.c::SiS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200610232342.07458.jesper.juhl@gmail.com>
Date:	Mon, 23 Oct 2006 23:42:07 +0200
From:	Jesper Juhl <jesper.juhl@...il.com>
To:	David Rientjes <rientjes@...washington.edu>
Cc:	linux-kernel@...r.kernel.org,
	Thomas Winischhofer <thomas@...ischhofer.net>
Subject: Re: [PATCH] Fix use of uninitialized variable in drivers/video/sis/init301.c::SiS_DDC2Delay()

On Monday 23 October 2006 23:26, David Rientjes wrote:
> On Mon, 23 Oct 2006, Jesper Juhl wrote:
> 
> > The variable 'j' is used uninitialized in the loop. Fix by initializing it to zero.
> > 
[snip]
> 
> I doubt this patch compile tested.
> 
You are right. I hang my head in shame and admit I did not compile test this one.
Fixed patch below.


Signed-off-by: Jesper Juhl <jesper.juhl@...il.com>
---

 drivers/video/sis/init301.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/video/sis/init301.c b/drivers/video/sis/init301.c
index f13fadd..45a5969 100644
--- a/drivers/video/sis/init301.c
+++ b/drivers/video/sis/init301.c
@@ -445,7 +445,8 @@ #endif
 void
 SiS_DDC2Delay(struct SiS_Private *SiS_Pr, unsigned int delaytime)
 {
-   unsigned int i, j;
+   unsigned int i;
+   unsigned int j = 0;
 
    for(i = 0; i < delaytime; i++) {
       j += SiS_GetReg(SiS_Pr->SiS_P3c4,0x05);


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/