linux-kernel - Re: [PATCH] Use extents for recording what swap is allocated.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1161644650.7033.23.camel@nigel.suspend2.net>
Date:	Tue, 24 Oct 2006 09:04:10 +1000
From:	Nigel Cunningham <ncunningham@...uxmail.org>
To:	Pavel Machek <pavel@....cz>
Cc:	Andrew Morton <akpm@...l.org>, "Rafael J. Wysocki" <rjw@...k.pl>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Use extents for recording what swap is allocated.

Hi.

On Mon, 2006-10-23 at 17:32 +0200, Pavel Machek wrote:
> Hi!
> 
> > Switch from bitmaps to using extents to record what swap is allocated;
> > they make more efficient use of memory, particularly where the allocated
> > storage is small and the swap space is large.
> 
> > This is also part of the ground work for implementing support for
> > supporting multiple swap devices.
> 
> bitmaps were more efficient and longer than original code... I did not
> _like_ them, but they are in now. I'd hate to change the code again,
> for what, 0.5% gain?

0.5% of what? This is part of what is needed to implement support for
multiple swap devices. You could extend what you already have,
implementing bitmaps that require a bit for every page of swap the user
has swapon'd, but that doesn't seem efficient to me.

> ...and this is still longer than bitmaps.
> 
> And SNAPSHOT_GET_SWAP_PAGE seems to support multiple swap spaces
> already.

It may do, but swap.c certainly doesn't. It supports exactly one device.

Regards,

Nigel

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/