| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1061023070801.29256@suse.de> Date: Mon, 23 Oct 2006 17:08:01 +1000 From: NeilBrown <neilb@...e.de> To: Andrew Morton <akpm@...l.org> Cc: linux-raid@...r.kernel.org, linux-kernel@...r.kernel.org Subject: [PATCH 003 of 4] md: Fix up maintenance of ->degraded in multipath. A recent fix which made sure ->degraded was initialised properly exposed a second bug - ->degraded wasn't been updated when drives failed or were hot-added. Signed-off-by: Neil Brown <neilb@...e.de> ### Diffstat output ./drivers/md/multipath.c | 2 ++ 1 file changed, 2 insertions(+) diff .prev/drivers/md/multipath.c ./drivers/md/multipath.c --- .prev/drivers/md/multipath.c 2006-10-23 16:34:54.000000000 +1000 +++ ./drivers/md/multipath.c 2006-10-23 16:35:38.000000000 +1000 @@ -277,6 +277,7 @@ static void multipath_error (mddev_t *md set_bit(Faulty, &rdev->flags); set_bit(MD_CHANGE_DEVS, &mddev->flags); conf->working_disks--; + mddev->degraded++; printk(KERN_ALERT "multipath: IO failure on %s," " disabling IO path. \n Operation continuing" " on %d IO paths.\n", @@ -336,6 +337,7 @@ static int multipath_add_disk(mddev_t *m blk_queue_max_sectors(mddev->queue, PAGE_SIZE>>9); conf->working_disks++; + mddev->degraded--; rdev->raid_disk = path; set_bit(In_sync, &rdev->flags); rcu_assign_pointer(p->rdev, rdev); - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists