linux-kernel - Re: [PATCH] pvrusb2: use NULL instead of 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <200610241421.k9OELHj6005788@laptop13.inf.utfsm.cl>
Date:	Tue, 24 Oct 2006 11:21:17 -0300
From:	"Horst H. von Brand" <vonbrand@....utfsm.cl>
To:	Randy Dunlap <randy.dunlap@...cle.com>
cc:	video4linux-list@...hat.com, lkml <linux-kernel@...r.kernel.org>,
	akpm <akpm@...l.org>, isely@...ox.com, slts@...e.fr
Subject: Re: [PATCH] pvrusb2: use NULL instead of 0 

Randy Dunlap <randy.dunlap@...cle.com> wrote:
> From: Randy Dunlap <randy.dunlap@...cle.com>
> 
> Fix sparse NULL usage warnings:
> drivers/media/video/pvrusb2/pvrusb2-v4l2.c:714:14: warning: Using plain integer as NULL pointer
> drivers/media/video/pvrusb2/pvrusb2-v4l2.c:715:16: warning: Using plain integer as NULL pointer
> drivers/media/video/pvrusb2/pvrusb2-v4l2.c:1079:10: warning: Using plain integer as NULL pointer
> drivers/media/video/pvrusb2/pvrusb2-cx2584x-v4l.c:224:58: warning: Using plain integer as NULL pointer
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>
> ---
>  drivers/media/video/pvrusb2/pvrusb2-cx2584x-v4l.c |    2 +-
>  drivers/media/video/pvrusb2/pvrusb2-v4l2.c        |    6 +++---
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> --- linux-2.6.19-rc2-git8.orig/drivers/media/video/pvrusb2/pvrusb2-cx2584x-v4l.c
> +++ linux-2.6.19-rc2-git8/drivers/media/video/pvrusb2/pvrusb2-cx2584x-v4l.c
> @@ -221,7 +221,7 @@ static unsigned int decoder_describe(str
>  static void decoder_reset(struct pvr2_v4l_cx2584x *ctxt)
>  {
>  	int ret;
> -	ret = pvr2_i2c_client_cmd(ctxt->client,VIDIOC_INT_RESET,0);
> +	ret = pvr2_i2c_client_cmd(ctxt->client,VIDIOC_INT_RESET,NULL);

Should be, per Coding-style:

        ret = pvr2_i2c_client_cmd(ctxt->client, VIDIOC_INT_RESET, NULL);

There is more similar stuff in the patch. Why not clean that up in the
same sweep?
-- 
Dr. Horst H. von Brand                   User #22616 counter.li.org
Departamento de Informatica                    Fono: +56 32 2654431
Universidad Tecnica Federico Santa Maria             +56 32 2654239
Casilla 110-V, Valparaiso, Chile               Fax:  +56 32 2797513
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/