linux-kernel - Re: [PATCH 1/5] netpoll: use sk_buff

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20061024075130.6e4cf8d2@dads-laptop>
Date:	Tue, 24 Oct 2006 07:51:30 -0700
From:	Stephen Hemminger <shemminger@...l.org>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/5] netpoll: use sk_buff_head for txq

On Mon, 23 Oct 2006 23:03:50 -0700 (PDT)
David Miller <davem@...emloft.net> wrote:

> From: Stephen Hemminger <shemminger@...l.org>
> Date: Mon, 23 Oct 2006 12:02:53 -0700
> 
> > +	spin_lock_irqsave(&netpoll_txq.lock, flags);
> > +	for (skb = (struct sk_buff *)netpoll_txq.next;
> > +	     skb != (struct sk_buff *)&netpoll_txq; skb = next) {
> > +		next = skb->next;
> > +		if (skb->dev == dev) {
> > +			skb_unlink(skb, &netpoll_txq);
> > +			kfree_skb(skb);
> > +		}
> >  	}
> > +	spin_unlock_irqrestore(&netpoll_txq.lock, flags);
> 
> IRQ's are disabled, I think we can't call kfree_skb() in such a
> context.

It is save since the skb's only come from this code (no destructors).

> 
> That's why zap_completion_queue() has all of these funny
> skb->destructor checks and such, all of this stuff potentially runs in
> IRQ context.

It should use __kfree_skb in the purge routine (like other places).
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/