linux-kernel - Re: [PATCH 9/13] KVM: define exit handlers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <453D66C6.5080008@us.ibm.com>
Date:	Mon, 23 Oct 2006 20:05:10 -0500
From:	Anthony Liguori <aliguori@...ibm.com>
To:	Avi Kivity <avi@...ranet.com>
CC:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 9/13] KVM: define exit handlers

Avi Kivity wrote:
> +static int handle_external_interrupt(struct kvm_vcpu *vcpu,
> +				     struct kvm_run *kvm_run)
> +{
> +	++kvm_stat.irq_exits;
> +	return 1;
> +}
>   

Don't you need to propagate the interrupt here?  In Xen, we inject the 
interrupt using the IDT.  As a module, you don't have access to that.  
However, you could use a software interrupt to reraise it.

I got your code running this afternoon (it's quite cool) but I noticed a 
ton of "rtc: lost some interrupts at 1024Hz." messages which leads me to 
believe.. you're dropping interrupts :-)  Things seem to hang trying to 
bring up eth0 in the guest.

BTW, have you setup a mailing list yet?

Regards,

Anthony Liguori
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/