linux-kernel - Re: -rt7 announcement? (was Re: 2.6.18-rt6) and more info about a compile error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1161664706.22373.48.camel@localhost.localdomain>
Date:	Tue, 24 Oct 2006 06:38:25 +0200
From:	Thomas Gleixner <tglx@...utronix.de>
To:	sergio@...giomb.no-ip.org
Cc:	Lee Revell <rlrevell@...-job.com>, Ingo Molnar <mingo@...e.hu>,
	linux-kernel@...r.kernel.org, John Stultz <johnstul@...ibm.com>,
	"Paul E. McKenney" <paulmck@...ibm.com>,
	Dipankar Sarma <dipankar@...ibm.com>,
	Arjan van de Ven <arjan@...radead.org>,
	Mike Galbraith <efault@....de>,
	Daniel Walker <dwalker@...sta.com>,
	Manish Lachwani <mlachwani@...sta.com>, bastien.dugue@...l.net
Subject: Re: -rt7 announcement? (was Re: 2.6.18-rt6) and more info about a
	compile error

On Tue, 2006-10-24 at 02:26 +0100, Sergio Monteiro Basto wrote:
> On Mon, 2006-10-23 at 16:40 -0400, Lee Revell wrote:
> > On Mon, 2006-10-23 at 21:26 +0100, Sergio Monteiro Basto wrote:
> > > rt7 should be to be applied on 2.6.18.1 
> > > still for 2.6.18 
> > > 
> > 
> > The -rt patch has always been against the most recent base kernel.  It
> > could be rebased against -stable but that would be more work for the
> > maintainers...
>  
> For me the most recent stable kernel is 2.6.18.1. 
> Normally change for .1 are very small but in this case I got 1, just 1,
> reject which I don't know to fix and prefer don't try it. My luck is the
> rej in a sparc arch and I can ignore it.

-rtXX is always against 2.6.X, never against the .stable versions.

> I got this compile error if I don't use CONFIG_PREEMPT_BKL in .config
> 
> kernel/rtmutex.c:938:48: error: macro "rt_release_bkl" passed 2
> arguments, but takes just 1
> kernel/rtmutex.c: In function 'rt_mutex_slowlock':
> kernel/rtmutex.c:938: error: 'rt_release_bkl' undeclared (first use in
> this function)
> kernel/rtmutex.c:938: error: (Each undeclared identifier is reported
> only once
> kernel/rtmutex.c:938: error: for each function it appears in.)

Fix below.

	tglx

Index: linux-2.6.18/kernel/rtmutex.c
===================================================================
--- linux-2.6.18.orig/kernel/rtmutex.c	2006-10-24 06:33:02.000000000 +0200
+++ linux-2.6.18/kernel/rtmutex.c	2006-10-24 06:31:55.000000000 +0200
@@ -902,7 +902,10 @@ static inline void rt_reacquire_bkl(int 
 }
 
 #else
-# define rt_release_bkl(x)	(-1)
+static inline int rt_release_bkl(struct rt_mutex *lock, unsigned long flags)
+{
+	return -1;
+}
 # define rt_reacquire_bkl(x)	do { } while (0)
 #endif
 


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/